OperatorAll - implement backpressure and include last value in exception cause #2986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| import org.apache.commons.math3.analysis.FunctionUtils; |
There was a problem hiding this comment.
External package reference!
import org.apache.commons.math3.analysis.FunctionUtils;
|
oops, fixed. |
| if (!result && !done) { | ||
| done = true; | ||
| child.onNext(false); | ||
| child.onCompleted(); | ||
| producer.setValue(false); | ||
| unsubscribe(); | ||
| } else { | ||
| // if we drop values we must replace them upstream as downstream won't receive and request more |
There was a problem hiding this comment.
This case is no longer necessary because the subscriber requests Long.MAX_VALUE upfront.
…e if exception occurs
|
Thanks, I've updated the commit with that change. |
|
Looks good now. Thanks! |
akarnokd
added a commit
that referenced
this pull request
May 28, 2015
OperatorAll - implement backpressure and include last value in exception cause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented backpressure using
SingleDelayedProducer(thanks @akarnokd) and while I was there ensured that the last value is in the exception cause when the predicate throws an exception.