1.x: Add action != null check in OperatorFinally #3436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,6 +33,9 @@ | |||
| final Action0 action; | |||
|
|
|||
| public OperatorFinally(Action0 action) { | |||
| if (action == null) { | |||
There was a problem hiding this comment.
I'd rather put these checks into Observable.
There was a problem hiding this comment.
This operator will be used in Single.finallyDo(), I don't want to copy-paste this :)
There was a problem hiding this comment.
The benefit of having the null check in the caller is that there is no allocation happening in case the action is null.
There was a problem hiding this comment.
Saving one allocation does not matter in this case because in most of the cases app will crash after this exception :)
|
👍 |
akarnokd
changed the title
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Nov 13, 2015
…-action-check 1.x: Add action != null check in OperatorFinally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3435.
Personally, I'd also add same test to
Observable.finallyDo()andSingle.finallyDo()because there are no guarantees that in future they will use exact same operator as implementation and this contract is more a contract ofObservable.finallyDo()andSingle.finallyDo().