Skip to content

1.x: add never test for PublishSubjectTest #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2016
Merged

1.x: add never test for PublishSubjectTest #3592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b24634
add never test for PublishSuibjectText
Chaoba Dec 30, 2015
fe75d05
add verifyNoMoreInteractions(observer) for PublishSuibjectText
Chaoba Dec 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/test/java/rx/subjects/PublishSubjectTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;

import java.util.ArrayList;
import java.util.concurrent.atomic.AtomicInteger;
Expand Down Expand Up @@ -63,7 +64,7 @@ public void testCompleted() {
subject.onError(new Throwable());

assertCompletedObserver(observer);
// todo bug? assertNeverObserver(anotherObserver);
assertNeverObserver(anotherObserver);
}

@Test
Expand Down Expand Up @@ -113,8 +114,20 @@ private void assertCompletedObserver(Observer<String> observer) {
verify(observer, times(1)).onNext("one");
verify(observer, times(1)).onNext("two");
verify(observer, times(1)).onNext("three");
verify(observer, never()).onNext("four");
verify(observer, never()).onError(any(Throwable.class));
verify(observer, times(1)).onCompleted();
verifyNoMoreInteractions(observer);
}

private void assertNeverObserver(Observer<String> observer) {
verify(observer, never()).onNext("one");
verify(observer, never()).onNext("two");
verify(observer, never()).onNext("three");
verify(observer, never()).onNext("four");
verify(observer, never()).onError(any(Throwable.class));
verify(observer, times(1)).onCompleted();
verifyNoMoreInteractions(observer);
}

@Test
Expand All @@ -139,7 +152,7 @@ public void testError() {
subject.onCompleted();

assertErrorObserver(observer);
// todo bug? assertNeverObserver(anotherObserver);
assertNeverErrorObserver(anotherObserver);
}

private void assertErrorObserver(Observer<String> observer) {
Expand All @@ -148,6 +161,17 @@ private void assertErrorObserver(Observer<String> observer) {
verify(observer, times(1)).onNext("three");
verify(observer, times(1)).onError(testException);
verify(observer, never()).onCompleted();
verifyNoMoreInteractions(observer);
}

private void assertNeverErrorObserver(Observer<String> observer) {
verify(observer, never()).onNext("one");
verify(observer, never()).onNext("two");
verify(observer, never()).onNext("three");
verify(observer, never()).onNext("four");
verify(observer, times(1)).onError(any(Throwable.class));
verify(observer, never()).onCompleted();
verifyNoMoreInteractions(observer);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll want verifyNoMoreInteractions(observer) to end these two methods, otherwise sending an onNext of "five" would not fail the test.


@Test
Expand Down