2.x: first step switching to the reduced-allocation architecture #4030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,6 +33,7 @@ | |||
| /** The cache and replay state. */ | |||
| private CacheState<T> state; | |||
|
|
|||
| private AtomicBoolean once; | |||
|
lgtm 👍 |
akarnokd
force-pushed
the
ArchitectureChange
branch
from
ff57e69 to
eb0c28e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards the new architecture where operator implementations are themselves of the base type instead of a 2-3 layer indirection as in 1.x.
This PR removes the instance field
onSubscribefrom the base reactive classes and introducessubscribeActualto be overridden with the custom operator logic now on. Existing operators are still working through the classical OnSubscribe/Lift indirection and will be updated in subsequent PRs.Naming and existence of
subscribeActualis up for (post-merge) discussion. To recap, the method is needed so that the defaultsubscribemethod can be made final and ensure plugin hooks can be called (once available). The method is protected and only affects operator implementors that chose to extend the base reactive classes directly.The alternative is to leave
subscribeabstract and add a hook to every operator method (for example, see this and this.