1.x: add missing javadoc elements, fix some descriptions #4039
Conversation
akarnokd
commented
Jun 20, 2016
akarnokd
commented
- Fixes to Javadoc warnings
- Type arguments
- Missing descriptions
| @@ -1127,6 +1132,7 @@ public final Completable compose(CompletableTransformer transformer) { | |||
| * <dd>{@code andThen} does not operate by default on a particular {@link Scheduler}.</dd> | |||
| * </dl> | |||
| * | |||
| * @param <T> the value type of the next Observable | |||
There was a problem hiding this comment.
Thanks. Once I'm done with the rearchitecting in the 2.x branch, I'll update the PR.
|
Fixed, @artem-zinnatullin . |
| @@ -29,7 +29,7 @@ | |||
| * | |||
| * @param <M> the event/message type | |||
| */ | |||
| interface MessagePassingQueue<M> { | |||
| public interface MessagePassingQueue<M> { | |||
There was a problem hiding this comment.
javadoc complained that the spsc queues reference it but it is not visible enough.
There was a problem hiding this comment.
Ah, because spsc queues are public but interface they're implementing is
not. Ok then!
On Mon, 20 Jun 2016, 16:00 David Karnok, [email protected] wrote:
In src/main/java/rx/internal/util/unsafe/MessagePassingQueue.java
#4039 (comment):@@ -29,7 +29,7 @@
*
- @param the event/message type
*/
-interface MessagePassingQueue {
+public interface MessagePassingQueue {javadoc complained that the spsc queues reference it but it is not
visible enough.—
You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub
https://github.com/ReactiveX/RxJava/pull/4039/files/12e00d19d0ac9c82eefd8f83a6f6bba7e0ea53b2#r67684701,
or mute the thread
https://github.com/notifications/unsubscribe/AA7B3HF0gIVikH3WAb6RfWHi7_UVir0Lks5qNo78gaJpZM4I5a4v
.
|
👍 |
1 similar comment
|
👍 |
|
Thanks @stevegury & @artem-zinnatullin @DavidMGross let me know if you are okay with the update. |
|
👍 Love it. Nice to see those @warn messages going away. |
