CachedThreadScheduler should wait until the previous action (if any) … #4231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…completes before releasing a worker to the pool. Fixes ReactiveX#4230.
Current coverage is 84.14% (diff: 100%)@@ 1.x #4231 diff @@
==========================================
Files 265 265
Lines 17314 17316 +2
Methods 0 0
Messages 0 0
Branches 2627 2627
==========================================
- Hits 14595 14571 -24
- Misses 1875 1890 +15
- Partials 844 855 +11
|
| pool.release(threadWorker); | ||
|
|
||
| // Release the worker _after_ the previous action (if any) has completed | ||
| threadWorker.schedule(new Action0() { |
There was a problem hiding this comment.
EventLoopWorker can implement Action0 and schedule itself to release.
There was a problem hiding this comment.
@akarnokd What would be the advantage of doing so?
There was a problem hiding this comment.
It saves an allocation; I believe io() workers are used and unsubscribed frequently enough to save on this allocation.
There was a problem hiding this comment.
Makes sense, let me change it.
…release. This saves an allocation.
|
👍 Given a misbehaving task, this at least prevents other work to be scheduled on the same pool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…completes before releasing a worker to the pool. Fixes #4230.