Skip to content

save allocation in OnSubscribeAmb #4232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2016
Merged

save allocation in OnSubscribeAmb #4232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions src/main/java/rx/internal/operators/OnSubscribeAmb.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,12 +320,12 @@ private boolean isSelected() {
if (chosen) {
return true;
}
if (selection.choice.get() == this) {
if (selection.get() == this) {
// fast-path
chosen = true;
return true;
} else {
if (selection.choice.compareAndSet(null, this)) {
if (selection.compareAndSet(null, this)) {
selection.unsubscribeOthers(this);
chosen = true;
return true;
Expand All @@ -338,12 +338,12 @@ private boolean isSelected() {
}
}

static final class Selection<T> {
final AtomicReference<AmbSubscriber<T>> choice = new AtomicReference<AmbSubscriber<T>>();
@SuppressWarnings("serial")
static final class Selection<T> extends AtomicReference<AmbSubscriber<T>> {
final Collection<AmbSubscriber<T>> ambSubscribers = new ConcurrentLinkedQueue<AmbSubscriber<T>>();

public void unsubscribeLosers() {
AmbSubscriber<T> winner = choice.get();
AmbSubscriber<T> winner = get();
if(winner != null) {
unsubscribeOthers(winner);
}
Expand All @@ -367,15 +367,14 @@ private OnSubscribeAmb(Iterable<? extends Observable<? extends T>> sources) {
@Override
public void call(final Subscriber<? super T> subscriber) {
final Selection<T> selection = new Selection<T>();
final AtomicReference<AmbSubscriber<T>> choice = selection.choice;

//setup unsubscription of all the subscribers to the sources
subscriber.add(Subscriptions.create(new Action0() {

@Override
public void call() {
AmbSubscriber<T> c;
if ((c = choice.get()) != null) {
if ((c = selection.get()) != null) {
// there is a single winner so we unsubscribe it
c.unsubscribe();
}
Expand All @@ -399,7 +398,7 @@ public void call() {
// if all sources were backpressure aware then this check
// would be pointless given that 0 was requested above from each ambSubscriber
AmbSubscriber<T> c;
if ((c = choice.get()) != null) {
if ((c = selection.get()) != null) {
// Already chose one, the rest can be skipped and we can clean up
selection.unsubscribeOthers(c);
return;
Expand All @@ -416,7 +415,7 @@ public void call() {
@Override
public void request(long n) {
AmbSubscriber<T> c;
if ((c = choice.get()) != null) {
if ((c = selection.get()) != null) {
// propagate the request to that single Subscriber that won
c.requestMore(n);
} else {
Expand All @@ -425,7 +424,7 @@ public void request(long n) {
if (!ambSubscriber.isUnsubscribed()) {
// make a best endeavours check to not waste requests
// if first emission has already occurred
if (choice.get() == ambSubscriber) {
if (selection.get() == ambSubscriber) {
ambSubscriber.requestMore(n);
// don't need to request from other subscribers because choice has been made
// and request has gone to choice
Expand Down