collect, DeferredScalarSubscriber - prevent multiple terminal emissions #4252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmoten
force-pushed
the
collect-prevent-multiple-terminal-events
branch
from
c25901d to
9d92adf
Compare
| ts.assertNotCompleted(); | ||
| assertEquals(Arrays.asList(e2), list); | ||
| } finally { | ||
| RxJavaHooks.setOnError(null); |
There was a problem hiding this comment.
You have to call reset otherwise RxJavaHooks wont delegate back to RxJavaPlugins.
There was a problem hiding this comment.
Ah, ok, I see from the source that your are right thus the javadoc on setOnError is wrong (or setOnError needs fixing).
davidmoten
force-pushed
the
collect-prevent-multiple-terminal-events
branch
2 times, most recently
from
1d89bc5 to
3b5dd7e
Compare
Current coverage is 84.36% (diff: 100%)@@ 1.x #4252 diff @@
==========================================
Files 266 267 +1
Lines 17446 17460 +14
Methods 0 0
Messages 0 0
Branches 2657 2660 +3
==========================================
+ Hits 14713 14731 +18
+ Misses 1873 1867 -6
- Partials 860 862 +2
|
davidmoten
force-pushed
the
collect-prevent-multiple-terminal-events
branch
from
3b5dd7e to
d51bb46
Compare
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #4242, if an operator maps an
onNextemission to anonErroremission downstream then it needs be defensive about another event being sent from upstream even if upstream has been unsubscribed.DeferredScalarSubscriberhas been updated with adoneflagObservableTeststo new classOnSubscribeCollectTest