1.x: fix SingleTest generics warnings #4254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 didn't see those since I have Java 8 as default in my IDE |
|
I'm using Eclipse which turned out to be an excellent tool to warn about these things. Are you using IntelliJ? I've noticed that people using IntelliJ end up with such hidden problems (while IntelliJ for me complained about almost everything else when I loaded RxJava into it once). |
Current coverage is 84.30% (diff: 100%)@@ 1.x #4254 diff @@
==========================================
Files 266 266
Lines 17446 17446
Methods 0 0
Messages 0 0
Branches 2657 2657
==========================================
- Hits 14715 14707 -8
- Misses 1870 1879 +9
+ Partials 861 860 -1
|
|
Yes I'm using Android Studio which is based on IntelliJ. That's weird I had no problems loading the project into AS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the generics warnings in the new
Single.flatMapCompletableunit tests.