1.x: compact MultipleAssignment- and Serial-Subscriptions #4328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * A container of a Subscription that supports operations of SerialSubscription | ||
| * and MultipleAssignmentSubscription via methods (update, replace) and extends | ||
| * AtomicReference to reduce allocation count (beware the API leak of AtomicReference!). | ||
| * @since 1.1.9 |
There was a problem hiding this comment.
nit: do we really need this for internal classes?
|
👍 |
Current coverage is 84.38% (diff: 56.57%)@@ 1.x #4328 diff @@
==========================================
Files 268 270 +2
Lines 17478 17500 +22
Methods 0 0
Messages 0 0
Branches 2664 2677 +13
==========================================
+ Hits 14764 14768 +4
- Misses 1853 1876 +23
+ Partials 861 856 -5
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the allocation in
MultipleAssignmentSubscriptionandSerialSubscriptionby introducing a shared, compact underlying containerSequentialSubscription.I've updated
Worker.schedulePeriodicallyto use it directly.In addition, there is a behavior change with
MultipleAssignmentSubscription: it no longer retains the lastSubscriptionas it was likely to cause retention problems (and otherwise didn't make sense to me).The
SequentialSubscriptionfeature weak versions of the mutation methods that don't retry if there was a concurrent mutation: for some operations, not winning such races is fine./cc @JakeWharton @davidmoten @artem-zinnatullin