2.x: factor out inner classes from the base reactive types #4360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 68.65% (diff: 71.45%)@@ 2.x #4360 diff @@
==========================================
Files 434 439 +5
Lines 30952 31116 +164
Methods 0 0
Messages 0 0
Branches 4968 4971 +3
==========================================
+ Hits 21252 21363 +111
- Misses 7626 7669 +43
- Partials 2074 2084 +10
|
| } | ||
| } | ||
|
|
||
| public static <T> Predicate<T> equalsWith(T value) { |
There was a problem hiding this comment.
Is there any reason to use these static factories? The nested classes could just be public (or promoted to top-level) and referenced directly.
There was a problem hiding this comment.
To avoid public namespace cluttering.
There was a problem hiding this comment.
Please don't refactor this yet; working on repeatWhen/retryWhen fixes.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out the anonymous inner classes from the base reactive types and introduces the appropriate classes and methods in
*Helperenums.