2.x: Do not promise a new instance where we return a singleton. #4384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 69.63% (diff: 100%)@@ 2.x #4384 diff @@
==========================================
Files 449 449
Lines 32005 32005
Methods 0 0
Messages 0 0
Branches 5108 5108
==========================================
- Hits 22300 22287 -13
Misses 7566 7566
- Partials 2139 2152 +13
|
| @@ -97,8 +97,8 @@ public static Disposable empty() { | |||
| } | |||
|
|
|||
| /** | |||
| * Returns a new, disposed Disposable instance. | |||
| * @return a new, disposed Disposable instance | |||
| * Returns a disposed Disposable instance. | |||
There was a problem hiding this comment.
is this line even necessary? It's just duplicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.