Skip to content

1.x: Sync doOnEach java doc #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2016
Merged

1.x: Sync doOnEach java doc #4418

merged 1 commit into from
Aug 24, 2016

Conversation

vanniktech
Copy link
Collaborator

The other doOnEach function has the right java doc. Terminal events such as onCompleted / onError are also included in doOnEach.

@akarnokd
Copy link
Member

👍

@codecov-io
Copy link

Current coverage is 84.30% (diff: 100%)

Merging #4418 into 1.x will increase coverage by 0.06%

@@                1.x      #4418   diff @@
==========================================
  Files           270        270          
  Lines         17516      17516          
  Methods           0          0          
  Messages          0          0          
  Branches       2677       2677          
==========================================
+ Hits          14756      14767    +11   
+ Misses         1896       1886    -10   
+ Partials        864        863     -1   

Powered by Codecov. Last update 3aaed26...2e90948

@akarnokd akarnokd merged commit a5c9453 into ReactiveX:1.x Aug 24, 2016
@vanniktech vanniktech deleted the 1.x_dooneach_sync branch August 24, 2016 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants