1.x: Add extend() for Single and Completable. #4419
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.29% (diff: 100%)@@ 1.x #4419 diff @@
==========================================
Files 270 272 +2
Lines 17516 17528 +12
Methods 0 0
Messages 0 0
Branches 2677 2677
==========================================
- Hits 14792 14775 -17
- Misses 1869 1898 +29
Partials 855 855
|
| * @since (if this graduates from Experimental/Beta to supported, replace this parenthetical with the release number) | ||
| */ | ||
| @Experimental | ||
| public <R> R extend(Func1<? super CompletableOnSubscribe, ? extends R> conversion) { |
There was a problem hiding this comment.
The problem with this is that CompletableOnSubscribe is practucally useless; you'll have to call Completable.create() with it to get meaningful opererations. The whole method should be the same as to in 2.x. The Observable.extend was pushed hard back then disergarding my reservations.
Of course if you can give a compelling case why reduce the options for the conversion, I'm open minded.
There was a problem hiding this comment.
I agree, and would much prefer to()'s semantics.
Since extend() is still @Experimental we have that option...
There was a problem hiding this comment.
Closing and will make a new PR, since it might be a day or two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches
Observable.extend(). These are all@Experimental(includingObservable). Perhaps we want to rename them allto()to match 2.x?