2.x: add subscribeWith to get back the subscriber/observer fluently #4422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 69.56% (diff: 100%)@@ 2.x #4422 diff @@
==========================================
Files 454 454
Lines 32323 32331 +8
Methods 0 0
Messages 0 0
Branches 5214 5214
==========================================
+ Hits 22470 22491 +21
+ Misses 7651 7640 -11
+ Partials 2202 2200 -2
|
|
👍 |
| * @throws NullPointerException if {@code observer} is null | ||
| * @since 2.0 | ||
| */ | ||
| public final <E extends CompletableObserver> E subscribeWith(E observer) { |
There was a problem hiding this comment.
will there also be an overload that only takes onComplete? Or something that takes 2 arguments, onComplete & onError?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
subscribeWithmethods to the base reactive types to mainly help with the 1.x to 2.x changeover as 2.xsubscribe(Subscriber)return void instead of the resource/cancellation/unsubscription typeDisposable. See the javadocs and the unit test for example use.Related: #4400