2.x: coverage, fixes, cleanup 8/27-1 #4431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 70.90% (diff: 87.77%)@@ 2.x #4431 diff @@
==========================================
Files 454 453 -1
Lines 32371 32383 +12
Methods 0 0
Messages 0 0
Branches 5223 5233 +10
==========================================
+ Hits 22786 22962 +176
+ Misses 7447 7303 -144
+ Partials 2138 2118 -20
|
|
|
||
| @Override | ||
| public void onSubscribe(Disposable d) { | ||
| // not supported by this operator |
There was a problem hiding this comment.
throw assertion error to ensure it never happens?
There was a problem hiding this comment.
We don't support dispose() once the cache has subscribed but the upstream should still run - this method is a no-op. Throwing here is not allowed anyway.
However, I'm willing to extend the SingleCache (and the others) by implementing Disposable and people can then cast and cancel a cache() too.
There was a problem hiding this comment.
Ah. I don't think that's worth it. I just misunderstood the comment and thought "not allowed" instead of "not supported".
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single.cache()to be lock-free, to allocate less and work properlyEmptyObserverPublishSubjectto support cross-cancellationTestHelper.raceto use the current thread for one of the tasks