2.x: cleanup, bugfixes, coverage 8/27-2 #4434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1743,16 +1743,10 @@ public static int bufferSize() { | |||
| */ | |||
| @SchedulerSupport(SchedulerSupport.CUSTOM) | |||
| public static Observable<Long> interval(long initialDelay, long period, TimeUnit unit, Scheduler scheduler) { | |||
| if (initialDelay < 0) { | |||
| initialDelay = 0L; | |||
There was a problem hiding this comment.
Surprised we aren't throwing here (and others)
akarnokd
force-pushed
the
Coverage827_2
branch
from
8fe1243 to
dd435fd
Compare
| throw new IllegalArgumentException("skip > 0 required but it was " + count); | ||
| } | ||
| verifyPositive(count, "count"); | ||
| verifyPositive(skip, "skip"); |
There was a problem hiding this comment.
I think one of these is wrong because skip can be 0 but count cannot.
There was a problem hiding this comment.
Based on other methods in this diff I would guess verifyPositive rejects 0
There was a problem hiding this comment.
It creates buffers every index % skip so zero not allowed.
|
👍 |
Current coverage is 73.67% (diff: 92.59%)@@ 2.x #4434 diff @@
==========================================
Files 453 453
Lines 32383 32373 -10
Methods 0 0
Messages 0 0
Branches 5233 5220 -13
==========================================
+ Hits 22969 23852 +883
+ Misses 7300 6437 -863
+ Partials 2114 2084 -30
|
akarnokd
force-pushed
the
Coverage827_2
branch
from
dd435fd to
ff7d7ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single,CompletableandObservable