2.x: start reimplementing Maybe with up-to-date javadoc, tests and algo #4454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 75.96% (diff: 77.49%)@@ 2.x #4454 diff @@
==========================================
Files 499 485 -14
Lines 33620 33041 -579
Methods 0 0
Messages 0 0
Branches 5269 5240 -29
==========================================
+ Hits 24439 25098 +659
+ Misses 7181 5907 -1274
- Partials 2000 2036 +36
|
|
|
||
| /** | ||
| * Returns a {@link Maybe} that invokes passed function and emits its result for each new MaybeObserver that subscribes | ||
| * while considering {@code null} value from the callable as indication for valueless completion. |
akarnokd
force-pushed
the
Cleanup901_1
branch
from
cebbe6d to
340dccd
Compare
|
👍 |
|
Thanks @JakeWharton ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements the
Maybewith more up-to-date algorithms (the original was a copy-paste of some older Single and Completable code it seems) and adds javadoc and tests along the way. Not all operators have been rewritten yet (and no placeholders). Early adopters should refer to thetoXmethods on the base reactive types. The PR also adds theRxJavaPluginshooks to supportMaybe.In addition, I've fixed javadoc mistakes in the other base reactive types (referring to the wrong types).