2.x: coverage, bugfixes, 9/03-1 #4468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ObjectHelper.requireNonNull(unit, "unit is null"); | ||
| ObjectHelper.requireNonNull(scheduler, "scheduler is null"); | ||
|
|
||
| return RxJavaPlugins.onAssembly(new FlowableInterval(initialDelay, period, unit, scheduler)); | ||
| return RxJavaPlugins.onAssembly(new FlowableInterval(Math.max(0L, initialDelay), Math.max(0L, period), unit, scheduler)); |
There was a problem hiding this comment.
Why massage invalid values here when in other methods we throw IAE?
There was a problem hiding this comment.
Because ScheduledExecutorService is forgiving in this regard.
|
👍 |
akarnokd
force-pushed
the
Coverage902_2
branch
from
92d1494 to
4617b1f
Compare
Current coverage is 76.91% (diff: 79.07%)@@ 2.x #4468 diff @@
==========================================
Files 493 493
Lines 33546 33684 +138
Methods 0 0
Messages 0 0
Branches 5310 5315 +5
==========================================
+ Hits 25502 25907 +405
+ Misses 5980 5711 -269
- Partials 2064 2066 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flowable.sequenceEqual,Flowable.zipwhen errors are delayed,Flowable.onBackpressureBufferwhen errors are delayedNbpXin some placesObservableandFlowable