2.x: reduce blockingX overhead, move internal observers to common pkg #4491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 77.88% (diff: 58.49%)@@ 2.x #4491 diff @@
==========================================
Files 500 498 -2
Lines 33905 33875 -30
Methods 0 0
Messages 0 0
Branches 5325 5326 +1
==========================================
- Hits 26394 26382 -12
+ Misses 5541 5519 -22
- Partials 1970 1974 +4
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR compacts the
blockingXoperators by extendingCountDownLatchand implementingSingleObserver,CompletableObserverandMaybeObserverwith the necessary blocking await mechanics.Benchmark comparison (i7 4770, Windows 7 x64, Java 8u102):
In addition, the internal package
subscribers.singleandsubscribers.completablehas been removed and the classes moved intoio.reactivex.internal.observerspackage. The old blocking enum helpers were removed as well.The
BlockingSingleSubscriberandBlockingSingleObserverabstract classes have been renamed toBlockingBaseXto avoid name confusion (they have nothing to do with theSingletype).