2.x: Add Checkstyle for Trailing Whitespace

[vanniktech]

This will add checkstyle though it should not be executed together with Travis and hence does not fail the PR if there are. Also running ./gradlew checkstyleMain gives a list of places where trailing whitespace exists.

[JakeWharton]

it should not be executed together with Travis and hence does not fail the PR

Seems pointless to add then.

[codecov-io]

Current coverage is 78.01% (diff: 100%)

Merging #4497 into 2.x will increase coverage by 0.03%

@@                2.x      #4497   diff @@
==========================================
  Files           505        505          
  Lines         34357      34357          
  Methods           0          0          
  Messages          0          0          
  Branches       5383       5383          
==========================================
+ Hits          26791      26802    +11   
- Misses         5551       5561    +10   
+ Partials       2015       1994    -21   

Powered by Codecov. Last update 35281d5...154fe6b

[vanniktech]

Yeah having the same opinion but David doesn't want it to fail the PR.

[JakeWharton]

Then why fail local builds?

On Wed, Sep 7, 2016 at 12:57 PM Niklas Baudy [email protected]
wrote:

Yeah having the same opinion but David doesn't want it to fail the PR.

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#4497 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEEfeX4juPXMZcS0vBkp-2p-otHsT0ks5qnuzWgaJpZM4J3Dgb
.

[akarnokd]

For now, just run it with ./gradlew checkstyleMain sometimes.

[akarnokd]

Yet it does fail it https://travis-ci.org/ReactiveX/RxJava/builds/158395672#L205

[vanniktech]

Alright my bad #4505

I thought the checkstyle tasks would not be executed automatically though build executes check and checkstyle task hooked itself into check task.