2.x: Fix MaybeTimber by using scheduler and unit #4529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 79.21% (diff: 86.20%)@@ 2.x #4529 diff @@
==========================================
Files 524 527 +3
Lines 34980 35877 +897
Methods 0 0
Messages 0 0
Branches 5443 5482 +39
==========================================
+ Hits 27548 28421 +873
- Misses 5460 5487 +27
+ Partials 1972 1969 -3
|
| @@ -1238,7 +1238,7 @@ | |||
| } | |||
|
|
|||
| /** | |||
| * Returns a Flowable that emits one item after a specified delay on a specified Scheduler. | |||
| * Returns a Maybe that emits one item after a specified delay on a specified Scheduler. | |||
There was a problem hiding this comment.
I did a cleanup of bunch of these so you may need to rebase this after.
There was a problem hiding this comment.
This PR was created on the current 2.x so after you posted that earlier PR in any case if you cleaned this one up already I could also just revert this one change
|
|
||
| import io.reactivex.*; | ||
| import io.reactivex.internal.disposables.SequentialDisposable; | ||
| import io.reactivex.Completable; |
There was a problem hiding this comment.
Please update your IDE settings to not unroll * imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also one question why does
CompletableTimercheckif (!sd.isDisposed()) {before replacing but SingleTimer does not? I adjusted MaybeTimber to SingleTimer so I didn't add the check there either.However I feel like this should be consistent, can you elaborate which one is wanted?