Skip to content

2.x: add most relevant ~100 operators' Reactive-Streams TCK tests #4538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2016

Conversation

akarnokd
Copy link
Member

This PR adds about ~100 Reactive-Streams Test Compatibility Kit (TCK) tests of RxJava's most relevant operators and operation modes.

The PR also contains a behavior fix for unsubscribeOn that now stops propagating events if the cancelled because it may take arbitrary time for the scheduled cancellation to reach the upstream which generally keeps emitting in the meantime.

@akarnokd akarnokd added the Test label Sep 12, 2016
@akarnokd akarnokd added this to the 2.0 RC 3 milestone Sep 12, 2016
@codecov-io
Copy link

codecov-io commented Sep 12, 2016

Current coverage is 78.66% (diff: 21.42%)

Merging #4538 into 2.x will increase coverage by 0.01%

@@                2.x      #4538   diff @@
==========================================
  Files           530        530          
  Lines         35324      35334    +10   
  Methods           0          0          
  Messages          0          0          
  Branches       5476       5482     +6   
==========================================
+ Hits          27781      27794    +13   
- Misses         5558       5571    +13   
+ Partials       1985       1969    -16   

Powered by Codecov. Last update 988cf23...33024ba

@akarnokd akarnokd merged commit c60a21a into ReactiveX:2.x Sep 13, 2016
@akarnokd akarnokd deleted the Tck912_1 branch September 13, 2016 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants