Skip to content

2.x: small cleanup and TCK fix #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2016
Merged

Conversation

akarnokd
Copy link
Member

  • Change the Callable<Publisher<T>> parameter of timeout to plain Publisher<T> to simplify the API surface; use defer(Callable<Publisher<T>>) as input instead
  • change the parameter order of timeout from (long, TimeUnit, Publisher, Scheduler) to (long, Timeunit, Scheduler, Publisher) to better match the general pattern of time-unit-scheduler.
  • Observable.timeout has been updated similarly
  • Add FlowableAwaitOnSubscribeTck to workaround the case when calling onNext (indirectly) from onSubscribe may be unexpected (plus randomly fails the observeOn TCK test).

@codecov-io
Copy link

codecov-io commented Sep 13, 2016

Current coverage is 78.67% (diff: 100%)

No coverage report found for 2.x at c030483.

Powered by Codecov. Last update c030483...0f25d69

@akarnokd akarnokd merged commit 666b05c into ReactiveX:2.x Sep 13, 2016
@akarnokd akarnokd deleted the Cleanup913_1 branch September 13, 2016 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants