2.x: cleanup of some javadoc errors and mentions of 'Nbp' #4542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
akarnokd
commented
Sep 13, 2016
akarnokd
commented
- fix some javadoc typos
- replace javadoc mentioning of "unsubscribe" with either "cancel" or "dispose"
- some minor algorithm reorganizations based on IntelliJ analysis
- remove the mention of "Nbp" from the code and documentation (it refers to an earlier naming scheme for Observables and Observers)
Current coverage is 78.62% (diff: 80.00%)@@ 2.x #4542 diff @@
==========================================
Files 530 530
Lines 35294 35271 -23
Methods 0 0
Messages 0 0
Branches 5478 5476 -2
==========================================
- Hits 27746 27732 -14
+ Misses 5561 5556 -5
+ Partials 1987 1983 -4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.