Skip to content

Scala Adaptor: TODO list and documentation #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2013

Conversation

samuelgruetter
Copy link
Contributor

More complete TODO list for Scala Adaptor and some documentation for CompletenessTest.

@cloudbees-pull-request-builder

RxJava-pull-requests #374 FAILURE
Looks like there's a problem with this pull request

@headinthebox
Copy link
Contributor

I have a fix ready for,.

Bring BooleanSubscription, CompositeSubscription, MultipleAssignmentSubscription to Scala, compositeSubscription.subscription = ...instead of setter method, add on CompositeSubscription should be +=

From: samuelgruetter [mailto:[email protected]]
Sent: Sunday, October 27, 2013 1:21 PM
To: Netflix/RxJava
Subject: [RxJava] Scala Adaptor: TODO list and documentation (#455)

More complete TODO list for Scala Adaptor and some documentation for CompletenessTest https://github.com/samuelgruetter/RxJava/blob/scalaadaptor/language-adaptors/rxjava-scala/src/test/scala/rx/lang/scala/CompletenessTest.scala .


You can merge this Pull Request by running

git pull https://github.com/samuelgruetter/RxJava scalaadaptor

Or view, comment on, or merge it at:

#455

Commit Summary

  • update TODOs according to meeting
  • Merge branch 'master' of github.com:Netflix/RxJava into scalaadaptor
  • add one TODO
  • some documentation for CompletenessTest

File Changes

Patch Links:

benjchristensen added a commit that referenced this pull request Oct 31, 2013
Scala Adaptor: TODO list and documentation
@benjchristensen benjchristensen merged commit 7b092ac into ReactiveX:master Oct 31, 2013
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
Scala Adaptor: TODO list and documentation
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
ReactiveX#455)

* Created a resilience4j-framework-common module which hosts common code which is shared between Spring Boot 1, Spring Boot 2, Ratpack and in future Micronaut.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants