Skip to content

2.x: make any() and all() return Single, patch up tests #4573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2016

Conversation

akarnokd
Copy link
Member

This PR changes the return type of any() and all() to Single.

I've also did a small change to TestObserver by having it implement the other XObserver types. This resulted in one extra method onSuccess to be added but now you can subscribe TestObserver to Single, Maybe and Completable without conversion yet still test() them with the same convenient API.

Flowable.range(1, 10).any(v -> true).test().assertResult(true);

@akarnokd akarnokd added this to the 2.0 RC 3 milestone Sep 21, 2016
@codecov-io
Copy link

codecov-io commented Sep 21, 2016

Current coverage is 78.61% (diff: 79.69%)

Merging #4573 into 2.x will decrease coverage by 0.10%

@@                2.x      #4573   diff @@
==========================================
  Files           530        534     +4   
  Lines         35337      35518   +181   
  Methods           0          0          
  Messages          0          0          
  Branches       5482       5504    +22   
==========================================
+ Hits          27815      27921   +106   
- Misses         5543       5610    +67   
- Partials       1979       1987     +8   

Powered by Codecov. Last update 994d8fc...2b73ef9

@akarnokd akarnokd merged commit 5d7f549 into ReactiveX:2.x Sep 21, 2016
@akarnokd akarnokd deleted the MoreSingleReturns branch September 21, 2016 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants