1.x: apply API promotions for 1.3 #5318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1.x #5318 +/- ##
============================================
- Coverage 84.46% 84.37% -0.09%
+ Complexity 2887 2881 -6
============================================
Files 290 290
Lines 18125 18124 -1
Branches 2479 2479
============================================
- Hits 15309 15292 -17
- Misses 1955 1966 +11
- Partials 861 866 +5
Continue to review full report at Codecov.
|
JakeWharton
approved these changes
Apr 27, 2017
| @@ -350,8 +348,8 @@ protected Observable(OnSubscribe<T> f) { | |||
| * @param <R> the resulting object type | |||
| * @param converter the function that receives the current Observable instance and returns a value | |||
| * @return the value returned by the function | |||
| * @since 1.3 | |||
There was a problem hiding this comment.
There's a lot of missing history below as well. Not sure if you were wanting it for every operator or not.
There was a problem hiding this comment.
If it was not recorded in place, I didn't bother looking them all up.
src/main/java/rx/Observable.java
Outdated
| @@ -402,10 +400,8 @@ protected Observable(OnSubscribe<T> f) { | |||
| * calls onCompleted | |||
| * @see <a href="http://reactivex.io/documentation/completable.html">ReactiveX documentation: | |||
| * Completable</a> | |||
| * @since (if this graduates from Experimental/Beta to supported, replace this parenthetical | |||
| * with the release number) | |||
| * @since 1 | |||
src/main/java/rx/SingleEmitter.java
Outdated
| @@ -24,11 +23,10 @@ | |||
| * <p> | |||
| * All methods are thread-safe; calling onSuccess or onError twice or one after the other has | |||
| * no effect. | |||
| * @since 1.2.3 - experimental (if this graduates from Experimental/Beta to supported, replace this parenthetical with the release number) | |||
| * | |||
| * <p>History: 1.2.3 -experimental | |||
There was a problem hiding this comment.
super nit: missing space after dash.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the API promotions of #5201.
Note that
Single.unsubscribeOnremainded experimental andObservable.fromEmitterwas removed.Where the experimental version was available, it was moved up as
<p>History: 1.x.y - experimentalsimilar to how 2.x versioning/promotions happen.Suggested review strategy:
@Experimentaland@Betaannotations are removed from the method and from Javadoc@since 1.3is present