Skip to content

2.x: attempt to fix a few time-sensitive tests. #5421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2017

Conversation

akarnokd
Copy link
Member

As of lately, the Travis CI runs much slower than usual and causes some time-sensitive tests to fail for some reason. This PR tries to figure out why this happens.

@codecov
Copy link

codecov bot commented Jun 16, 2017

Codecov Report

Merging #5421 into 2.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5421      +/-   ##
============================================
- Coverage     96.12%   96.12%   -0.01%     
+ Complexity     5787     5785       -2     
============================================
  Files           630      630              
  Lines         41232    41232              
  Branches       5728     5728              
============================================
- Hits          39636    39635       -1     
- Misses          625      627       +2     
+ Partials        971      970       -1
Impacted Files Coverage Δ Complexity Δ
...vex/internal/operators/single/SingleTakeUntil.java 86.88% <0%> (-8.2%) 2% <0%> (ø)
...in/java/io/reactivex/subjects/BehaviorSubject.java 83.85% <0%> (-7.82%) 56% <0%> (ø)
.../main/java/io/reactivex/subjects/MaybeSubject.java 95.65% <0%> (-4.35%) 46% <0%> (-2%)
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
.../internal/operators/flowable/FlowableInterval.java 94.44% <0%> (-2.78%) 3% <0%> (ø)
...java/io/reactivex/subjects/CompletableSubject.java 97.4% <0%> (-2.6%) 36% <0%> (-1%)
...ternal/operators/completable/CompletableUsing.java 97.61% <0%> (-2.39%) 4% <0%> (ø)
...main/java/io/reactivex/subjects/SingleSubject.java 95.23% <0%> (-2.39%) 38% <0%> (-1%)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
...x/internal/operators/flowable/FlowablePublish.java 92.95% <0%> (-2.21%) 9% <0%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9881df...6cd8bb5. Read the comment docs.

@akarnokd akarnokd merged commit f64fdd9 into ReactiveX:2.x Jun 16, 2017
@akarnokd akarnokd deleted the XFlatMapTestTimeFix branch June 16, 2017 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant