Skip to content

1.x: TestSubscriber::assertValuesAndClear should reset valueCount #5437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/rx/observers/TestSubscriber.java
Original file line number Diff line number Diff line change
Expand Up @@ -703,5 +703,6 @@ public final void assertValuesAndClear(T expectedFirstValue, T... expectedRestVa
assertItem(expectedRestValues[i], i + 1);
}
values.clear();
valueCount = 0;
}
}
2 changes: 1 addition & 1 deletion src/test/java/rx/observers/AssertableSubscriberTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public void testSingle() {
assertEquals(Thread.currentThread().getName(), ts.getLastSeenThread().getName());
assertTrue(ts.getOnErrorEvents().isEmpty());
assertTrue(ts.getOnNextEvents().isEmpty());
assertEquals(1, ts.getValueCount());
assertEquals(0, ts.getValueCount());
}

@Test
Expand Down
11 changes: 11 additions & 0 deletions src/test/java/rx/observers/TestSubscriberTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -815,4 +815,15 @@ public void assertAndConsume() {

ts.assertNoValues();
}

@Test
public void assertAndClearResetsValueCount() {
TestSubscriber<Integer> ts = TestSubscriber.create();

ts.onNext(1);
ts.assertValuesAndClear(1);

ts.assertNoValues();
Assert.assertEquals(0, ts.getValueCount());
}
}