Skip to content

Remove apostrophe to correct grammar. #5793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Remove apostrophe to correct grammar. #5793

merged 1 commit into from
Jan 5, 2018

Conversation

eventualbuddha
Copy link
Contributor

  • Please give a description about what and why you are contributing, even if it's trivial.

This pull request corrects a minor grammar issue in the README. In this case we want the 3rd person present form of "let", not the contraction "let us".

  • Please include the issue list number(s) or other PR numbers in the description if you are contributing in response to those.

n/a

  • Please include a reasonable set of unit tests if you contribute new code or change an existing one. If you contribute an operator, (if applicable) please make sure you have tests for working with an empty, just, range of values as well as an error source, with and/or without backpressure and see if unsubscription/cancellation propagates correctly.

n/a

In this case we want the 3rd person present form of "let", not the contraction "let us".
@codecov
Copy link

codecov bot commented Jan 5, 2018

Codecov Report

Merging #5793 into 2.x will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5793      +/-   ##
============================================
- Coverage     96.29%   96.25%   -0.04%     
- Complexity     5809     5810       +1     
============================================
  Files           634      634              
  Lines         41607    41607              
  Branches       5770     5770              
============================================
- Hits          40066    40050      -16     
- Misses          614      623       +9     
- Partials        927      934       +7
Impacted Files Coverage Δ Complexity Δ
.../operators/completable/CompletableConcatArray.java 93.75% <0%> (-6.25%) 2% <0%> (ø)
...in/java/io/reactivex/subjects/BehaviorSubject.java 86.24% <0%> (-5.83%) 54% <0%> (ø)
...nternal/operators/parallel/ParallelReduceFull.java 91.17% <0%> (-3.93%) 2% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.24% <0%> (-3.23%) 9% <0%> (ø)
...ternal/operators/observable/ObservablePublish.java 92.98% <0%> (-2.64%) 11% <0%> (+1%)
...nternal/operators/parallel/ParallelSortedJoin.java 92.75% <0%> (-2.18%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 91.97% <0%> (-2.14%) 5% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 97.24% <0%> (-1.84%) 39% <0%> (-1%)
...rnal/subscriptions/DeferredScalarSubscription.java 98.46% <0%> (-1.54%) 28% <0%> (-1%)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 709ccd6...e582cb4. Read the comment docs.

@akarnokd akarnokd merged commit 6aea3f0 into ReactiveX:2.x Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants