Skip to content

Single error operators marbles #6086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2018

Conversation

UMFsimke
Copy link
Contributor

Here are marbles for #5788

For error(Callable)
errorCallable

For error(Throwable), only added error event to be red:
errorThrowable

For onErrorReturn
onErrorReturn

For onErrorReturnItem
onErrorReturnItem

For onErrorResumeNext(SingleSource)
onErrorResumeNext

For onErrorResumeNext(Function)
onErrorResumeNextFn

@akarnokd akarnokd added this to the 2.2 milestone Jul 17, 2018
@akarnokd
Copy link
Member

For the onErrorX, please indicate the normal case via different marble (i.e., the usual split diagram).

Btw you can save yourself a commit if you follow the following naming in the JavaDocs:

https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Single.XXXX.png

where XXXX is the name of the operator, such as error and may contain argument indicator letters:

  • s is for Schedulers or Single
  • t is for timed
  • n is for some numerical value
  • f is for function or Flowable
  • c is for callable or Completable
  • p is for Publisher
  • m is for Maybe or some other numerical value

Thus, the image naming of this PR will look like this:

-https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Single.error.c.png
-https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Single.error.png
-https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Single.onErrorReturn.png
-https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Single.onErrorReturnItem.png
-https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Single.onErrorResumeNext.png
-https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Single.onErrorResumeNext.f.png

@codecov
Copy link

codecov bot commented Jul 17, 2018

Codecov Report

Merging #6086 into 2.x will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6086      +/-   ##
============================================
+ Coverage     98.25%   98.26%   +0.01%     
+ Complexity     6197     6195       -2     
============================================
  Files           667      667              
  Lines         44858    44858              
  Branches       6211     6211              
============================================
+ Hits          44076    44081       +5     
+ Misses          239      231       -8     
- Partials        543      546       +3
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 100% <100%> (ø) 146 <1> (ø) ⬇️
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.24% <0%> (-2.16%) 9% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-1.5%) 2% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 97.22% <0%> (-1.39%) 56% <0%> (-1%)
...ex/internal/operators/flowable/FlowableCreate.java 95.8% <0%> (-1.3%) 6% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-1.2%) 2% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 95.21% <0%> (-1.07%) 3% <0%> (ø)
...perators/mixed/ObservableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 3% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 98.2% <0%> (-0.9%) 59% <0%> (-1%)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ebd2c...50265d1. Read the comment docs.

@UMFsimke
Copy link
Contributor Author

Images are now updated and PR as well with proper URLs. Thanks for detailed explanation!

@akarnokd akarnokd merged commit fd4b614 into ReactiveX:2.x Jul 18, 2018
@UMFsimke UMFsimke deleted the SingleErrorOperatorsMarbles branch August 4, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants