Skip to content

fix(test): Each test class that uses JFX must init the JFX toolkit #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2019

Conversation

arnobl
Copy link
Contributor

@arnobl arnobl commented May 21, 2019

When executing the class JavaFxObservableTest alone several tests fail: the JFX tooltkit is not initialised.
The test class JavaFxSchedulerTest has a method initJFX that initialises the JFX toolkit. Yet, if JavaFxObservableTest is executed before this class, the tests will fail (which appends sometimes with gradle build).

Another change: if the toolkit has been already initialised by another test class, an annoying exception will be raised (IllegalStateException). Need to try/catch to ignore this exception.

@arnobl arnobl changed the title fix(test): Each test class that use JFX must init the JFX toolkit fix(test): Each test class that uses JFX must init the JFX toolkit May 21, 2019
@thomasnield thomasnield merged commit 2224bbd into ReactiveX:2.11.x May 23, 2019
@arnobl arnobl deleted the fix-tests-fxapp branch May 23, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants