-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Support project Catalyst #2012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support project Catalyst #2012
Conversation
This is excellent! If this works in Xcode 10 and builds, I'm all for it. Let's wait for CI. |
I've stared at this for a while, but I cant seem to find my way around this. It is parsed, even if we do something like |
@iamDecode I opened a bug in Swift Compiler: There seems to be a fix here, we might need to pull this in and bite the bullet, but let me think of options until tomorrow: |
I think it should be ok to just add It's probably better to allow users to use it with warnings than have it fail. |
Yup. That would be the only option here - it’s a parser but which was fixed but only for Xcode 11. Can you add it to Travis ? @iamDecode |
@freak4pc sure thing, I updated it! I added a bit of logic to only add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for your patience.
Using RxSwift in an iOS app compiled for Mac currently yields nasty errors because
UIWebView
is deprecated and not supported in UIKit for Mac:The official documentation states
#if !targetEnvironment(UIKitForMac)
is the best way of dealing with these issues (source).This PR adds some extra conditions to support compiling with project Catalyst.