ID as strings and Parsing array items

[YaphetKG]

There were two issues when I had used bulk loader with enforce schema,

• The column specified as ID needed to be an Integer, I tried computing the hash of the string I had tried to use that as an ID but I was getting errors from Struct suggesting the generated hash value was to long to convert.
• The second item was when parsing columns specified as Type array , it will try to detect the types of each item in the array. In doing so there are cases where we have items as strings that are not necessarily arrays for instance array that looks like ['selenophosphoric acid','trihydroxidoselenidophosphorus','[P(OH)3Se]'] , so I tried to catch the exception and pass it down

Please if you have better solutions to my approach I'd be happy to adopt

[lgtm-com]

This pull request introduces 1 alert when merging 7db461c into 516fa56 - view on LGTM.com

new alerts:

• 1 for Except block handles 'BaseException'

[lgtm-com]

This pull request introduces 1 alert when merging 25493a4 into 516fa56 - view on LGTM.com

new alerts:

• 1 for Except block handles 'BaseException'

[codecov]

Codecov Report

Merging #46 (516fa56) into master (516fa56) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   88.83%   88.83%           
=======================================
  Files           8        8           
  Lines         448      448           
=======================================
  Hits          398      398           
  Misses         50       50           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516fa56...25493a4. Read the comment docs.

[jeffreylovitz]

Hi @YaphetKG,

Thanks for the contributions! These look like sensible changes to me. Ultimately, the ID column should be able to specify its type, but until then it is more natural to default to strings rather than numerics.

[YaphetKG]

@jeffreylovitz Awesome thanks