configurable escapechar for csv reader #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreylovitz
approved these changes
Mar 2, 2021
There was a problem hiding this comment.
Thanks, @jvanmalder!
I have no objections to this PR as it's written; I think the flag and text are both fine.
There should probably be a corresponding test case that checks for both a custom escape character and no escape character, but I won't block the PR on that account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed more flexibility on the CSV reader, so I added another configuration option for the escapechar parameter.
Any feedback welcome, i.e. on the chosen short flag character or on the help text.