Skip to content

Add rust_random sample that uses module_misc_device. #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2021

Conversation

wedsonaf
Copy link

This is based on #219 and #218.

Provide a default `FileOpener` implementation for types that implement
`Default`, whose wrappers are `Box`, and that have no per-device shared
state.

Make `Box` the default wrapper, so that drivers only need to define
`Wrapper` if they need something different.

Signed-off-by: Wedson Almeida Filho <[email protected]>
It mimics the C version that allows a module to be defined that exposes
a misc device.

Signed-off-by: Wedson Almeida Filho <[email protected]>
@ojeda
Copy link
Member

ojeda commented Apr 23, 2021

GitHub should really have a way to see the final changes if a PR is merged without having to go commit by commit.

@ojeda ojeda merged commit 6ef7454 into Rust-for-Linux:rust Apr 23, 2021
@ojeda
Copy link
Member

ojeda commented Apr 23, 2021

@alex I assumed you were OK with this given the email; nevertheless please give the sample a second look if you can.

@alex
Copy link
Member

alex commented Apr 23, 2021

Yes indeed, still LGTM :-)

@wedsonaf wedsonaf deleted the sample branch April 23, 2021 17:10
@ojeda
Copy link
Member

ojeda commented Apr 23, 2021

Thanks @alex!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants