binder: replace Arc<Context> with Ref<Context>.
#393
Merged
+33
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wedson Almeida Filho <[email protected]>
|
Review of
|
TheSven73
approved these changes
Jun 28, 2021
| node: None, | ||
| uid: None, | ||
| }) | ||
| pub(crate) fn new() -> Result<Ref<Self>> { |
There was a problem hiding this comment.
I notice you're replacing Pin<Arc<T>> with Ref<T> here. This is of course correct, since Ref<T> is now "intrinsically pinned" (or whatever name we want to give it).
Would you perhaps be open to one of the following (or both):
- replace
Pin<Ref<T>>withRef<T>everywhere - rename
Ref<T>toPinRef<T>orPinnedRef<T>or some such
(this should of course not hold up this PR)
There was a problem hiding this comment.
Would you perhaps be open to one of the following (or both):
- replace
Pin<Ref<T>>withRef<T>everywhere
I will consider this as I switch users of Arc to Ref. I don't anticipate any challenges but I do run into them I'll rope you in.
- rename
Ref<T>toPinRef<T>orPinnedRef<T>or some such
I'm open to this, but I'm not convinced yet that it's a good idea. Mostly because being pinned is a property of Ref, but it's not a defining one (being ref-counted is).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wedson Almeida Filho [email protected]