Makefile: run Rust build on prepare
#667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some architectures add flags between `prepare0` and `prepare`. This makes e.g. `bindgen` think flags have changed. Thus, instead of running `build` in `prepare0`, do it a bit later in `prepare` since we do not need anything before. This solves the arm64 CI issues we were seeing since the container move: the CI now uses Clang 13 instead of 12, and Clang 13 introduced SysReg Stack Protector Guards which were being set. This also makes the PowerPC hack unnecessary, which was no longer needed anyway since commit 336868a ("powerpc: smp: remove hack to obtain offset of task_struct::cpu"). Signed-off-by: Miguel Ojeda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some architectures add flags between
prepare0andprepare.This makes e.g.
bindgenthink flags have changed.Thus, instead of running
buildinprepare0, do it a bit laterin
preparesince we do not need anything before.This solves the arm64 CI issues we were seeing since the container
move: the CI now uses Clang 13 instead of 12, and Clang 13
introduced SysReg Stack Protector Guards which were being set.
This also makes the PowerPC hack unnecessary, which was no
longer needed anyway since commit 336868a ("powerpc: smp:
remove hack to obtain offset of task_struct::cpu").
Signed-off-by: Miguel Ojeda [email protected]