rust: miscdev: support names created at runtime #677
Conversation
wedsonaf
force-pushed
the
miscdev-name
branch
from
af4b226 to
f45ee97
Compare
rust/kernel/miscdev.rs
Outdated
| Options::new().register_new(name, open_data) | ||
| } | ||
|
|
||
| /// Registers a miscellaneous device with the rest of the kernel. | ||
| /// | ||
| /// It must be pinned because the memory block that represents the registration is | ||
| /// self-referential. | ||
| pub fn register(self: Pin<&mut Self>, name: &'static CStr, open_data: T::OpenData) -> Result { | ||
| pub fn register(self: Pin<&mut Self>, name: fmt::Arguments<'_>, open_data: T::OpenData) -> Result { |
There was a problem hiding this comment.
Maybe accept Cow<'static, CStr> instead? That allows avoiding an allocation in the common case of the name being constant. Or impl Into<Cow<'static, CStr>> to allow directly passing in both a CStr and CString without having to construct a Cow<CStr>.
There was a problem hiding this comment.
I'd like to leave this as is now, and once #678 is done (or as part of it) we can optimise this avoid the allocation when using a &'static CStr
wedsonaf
force-pushed
the
miscdev-name
branch
from
f45ee97 to
3838d81
Compare
The registration now holds an owned C string while the miscdev is registered, and frees it on drop. Now names are formatted with the `fmt` macro instead of being static C strings. This enables scenarios when the device name is constructed at runtime, i.e., where a static C string does not exist. Signed-off-by: Wedson Almeida Filho <[email protected]>
wedsonaf
force-pushed
the
miscdev-name
branch
from
3838d81 to
df111f3
Compare
|
Rebased now that all dependencies are merged. |
Yes, definitely. Do you expect people will generate names dynamically for hwrng? |
Then I'm working on this.
Actually, this is the case in the trng driver already. The name for hwrng driver is set to the name of pdev. |
The registration now holds an owned C string while the miscdev is
registered, and frees it on drop.
Now names are formatted with the
fmtmacro instead of being staticC strings. This enables scenarios when the device name is constructed at
runtime, i.e., where a static C string does not exist.
Signed-off-by: Wedson Almeida Filho [email protected]