Skip to content

rust: fix rust-analyzer warning in macro #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

wedsonaf
Copy link

I get the following warning when using rust-analyzer and the module
macro:

Static variable __rust_fs_4 should have UPPER_SNAKE_CASE name, e.g.
__RUST_FS_4

This patch emits an uppercase name for the static, which makes the
warning go away.

Signed-off-by: Wedson Almeida Filho [email protected]

I get the following warning when using rust-analyzer and the `module`
macro:

Static variable `__rust_fs_4` should have UPPER_SNAKE_CASE name, e.g.
`__RUST_FS_4`

This patch emits an uppercase name for the static, which makes the
warning go away.

Signed-off-by: Wedson Almeida Filho <[email protected]>
@ojeda ojeda merged commit f42f82c into Rust-for-Linux:rust Jul 25, 2022
@ojeda
Copy link
Member

ojeda commented Jul 25, 2022

LGTM -- modinfo does not care about the symbol name.

@wedsonaf wedsonaf deleted the static-name branch September 17, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants