Modify PyType::name method to return BorrowedValue<str>
#3261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snowapril <[email protected]>
Signed-off-by: snowapril <[email protected]>
Signed-off-by: snowapril <[email protected]>
Snowapril
force-pushed
the
fix-issue-3232
branch
from
e2b6710 to
1deb59c
Compare
youknowone
approved these changes
Oct 10, 2021
|
Thank you for contributing! |
| self.name().to_string() | ||
| } | ||
|
|
||
| pub fn name(&self) -> BorrowedValue<str> { |
There was a problem hiding this comment.
Ah, looked at this too late, but it'd be better to have this be a RwLockReadGuard, since that's the only variant of BorrowedValue the function ever returns. It's kinda like the difference between returning a Box<ConcreteType> and a Box<dyn Trait> - sure, both have more or less the same functionality, but there's some amount of overhead with the type-erased form. (If you just want to hide implementation details you could return an impl Deref<Target=str> + fmt::Display + ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close issue #3232