fix(Form): Use shared context for Form and FormItem #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
every form item had his own context as it was part of the bundled file. Now the Form shares a context with the FormItems. Fixes #274
andybessm
approved these changes
Jan 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
=======================================
Coverage 73.82% 73.82%
=======================================
Files 161 161
Lines 3538 3538
Branches 615 615
=======================================
Hits 2612 2612
Misses 724 724
Partials 202 202
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
every form item had his own context as it was part of the bundled file. Now the Form shares a context with the FormItems.
Fixes #274