Skip to content

fix(FilterGroupItem): add colon to labels #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2023
Merged

fix(FilterGroupItem): add colon to labels #4378

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
387f9de
fix(FilterGroupItem): add colon to labels
Lukas742 Mar 20, 2023
2ba1a2c
Merge branch 'main' into fix/fgi-colon
Lukas742 Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/main/src/components/FilterGroupItem/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,12 @@ export const FilterGroupItem = forwardRef<HTMLDivElement, FilterGroupItemPropTyp
>
<TableCell>
<FlexBox direction={FlexBoxDirection.Column}>
<Label className={classes.dialogCellLabel} title={labelTooltip ?? label} required={required}>
<Label
className={classes.dialogCellLabel}
title={labelTooltip ?? label}
required={required}
showColon={withValues}
>
{label}
</Label>
{withValues && children}
Expand All @@ -133,7 +138,7 @@ export const FilterGroupItem = forwardRef<HTMLDivElement, FilterGroupItemPropTyp
<div ref={ref} slot={slot} {...rest} className={clsx(classes.filterItem, className)}>
<div className={inFB ? classes.innerFilterItemContainer : classes.innerFilterItemContainerDialog}>
<FlexBox>
<Label title={labelTooltip ?? label} required={required}>
<Label title={labelTooltip ?? label} required={required} showColon>
{`${considerGroupName && groupName !== 'default' ? `${groupName}: ` : ''}
${label}`}
</Label>
Expand Down