Skip to content

docs(CustomComponentsSlots): improve wording #4639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2023
Merged

docs(CustomComponentsSlots): improve wording #4639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/knowledge-base/CustomComponentsSlots.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ The `BarComponent` would compile to this:

<FaultyBarComponent />

As you can see, both custom components are not displayed.
As you can see, both custom components are not displayed in the right place.
Our wrapper does add the `slot` prop to the custom component, but the most outer HTML-Element/component (e.g. `<div>Start</div>`) does not accept it and therefore cannot use it.

To fix this the `slot` prop must also be passed to the outer element of the component:
Expand Down