Skip to content

chore: clean up old, unused inferfaces #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/main/src/components/FilterBar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { Button } from '@ui5/webcomponents-react/lib/Button';
import { ButtonDesign } from '@ui5/webcomponents-react/lib/ButtonDesign';
import React, { FC, forwardRef, ReactNode, ReactNodeArray, RefObject, useCallback, useState } from 'react';
import { createComponentStyles } from '@ui5/webcomponents-react-base/lib/createComponentStyles';
import { ClassProps } from '../../interfaces/ClassProps';
import { CommonProps } from '../../interfaces/CommonProps';
import styles from './FilterBar.jss';

Expand All @@ -17,7 +16,7 @@ export interface FilterBarPropTypes extends CommonProps {
children: ReactNode | ReactNodeArray;
}

interface FilterBarInternalProps extends FilterBarPropTypes, ClassProps {}
interface FilterBarInternalProps extends FilterBarPropTypes {}

const useStyles = createComponentStyles(styles, { name: 'FilterBar' });

Expand Down
3 changes: 1 addition & 2 deletions packages/main/src/interfaces/AnalyticalTableDomRef.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { AnalyticalTableScrollMode } from '@ui5/webcomponents-react/lib/AnalyticalTableScrollMode';

//@ts-ignore
export interface AnalyticalTableDomRef extends HTMLDivElement {
export interface AnalyticalTableDomRef extends Omit<HTMLDivElement, 'scrollTo'> {
scrollToItem: (index: number, align?: AnalyticalTableScrollMode) => void;
scrollTo: (scrollOffset: number) => void; //overrides native scrollTo function
}
7 changes: 0 additions & 7 deletions packages/main/src/interfaces/ClassProps.ts

This file was deleted.

7 changes: 0 additions & 7 deletions packages/main/src/interfaces/InputBaseItemType.ts

This file was deleted.

5 changes: 0 additions & 5 deletions packages/main/src/interfaces/ListItemShape.ts

This file was deleted.

3 changes: 0 additions & 3 deletions packages/main/src/interfaces/ObjectWithVariableKeys.ts

This file was deleted.

This file was deleted.