Skip to content

fix(DynamicPageTitle): spread breadcrumbs if only child #5001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix(DynamicPageTitle): spread breadcrumbs if only child #5001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion packages/main/src/components/DynamicPageTitle/DynamicPageTitle.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useRef, useState } from 'react';
import type { DynamicPageTitlePropTypes } from '../..';
import { DynamicPage, ObjectPage, Title } from '../..';
import { Breadcrumbs, BreadcrumbsItem, DynamicPage, ObjectPage, Title } from '../..';
import { Button } from '../../webComponents/index.js';
import { DynamicPageTitle } from './';

Expand Down Expand Up @@ -102,4 +102,46 @@ describe('DynamicPageTitle', () => {
cy.get('[data-component-name="ToolbarOverflowButton"]').should('be.visible');
});
});

it('breadcrumbs spread', () => {
[true, false].forEach((isObjectPage) => {
cy.viewport(1920, 1080);
cy.mount(
<PageComponent
isObjectPage={isObjectPage}
dynamicPageTitleProps={{
navigationActions: undefined,
breadcrumbs: (
<Breadcrumbs data-testid="breadcrumbs">
{new Array(14).fill(1337).map((item, index) => (
<BreadcrumbsItem key={index}>{`BreadcrumbsItem ${index}`}</BreadcrumbsItem>
))}
</Breadcrumbs>
)
}}
/>
);
// no nav actions
cy.findByTestId('breadcrumbs').parent().should('have.css', 'width', '1808px' /*100%*/);
cy.mount(
<PageComponent
isObjectPage={isObjectPage}
dynamicPageTitleProps={{
breadcrumbs: (
<Breadcrumbs data-testid="breadcrumbs">
{new Array(14).fill(1337).map((item, index) => (
<BreadcrumbsItem key={index}>{`BreadcrumbsItem ${index}`}</BreadcrumbsItem>
))}
</Breadcrumbs>
)
}}
/>
);
// nav actions in actions toolbar
cy.findByTestId('breadcrumbs').parent().should('have.css', 'width', '1808px' /*100%*/);
cy.viewport(1000, 1000);
// w/ nav actions
cy.findByTestId('breadcrumbs').parent().should('have.css', 'width', '460px' /*50% (min-width)*/);
});
});
});
5 changes: 4 additions & 1 deletion packages/main/src/components/DynamicPageTitle/DynamicPageTitle.jss.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ export const DynamicPageTitleStyles = {
},
breadcrumbs: {
minWidth: '50%',
padding: '0.5rem 0 0.25rem 0'
padding: '0.5rem 0 0.25rem 0',
'&:only-child': {
width: '100%'
}
},
titleMainSection: {
overflowX: 'hidden',
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/components/DynamicPageTitle/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ const DynamicPageTitle = forwardRef<HTMLDivElement, DynamicPageTitlePropTypes>((
{breadcrumbs}
</div>
)}
{showNavigationInTopArea && (
{navigationActions && showNavigationInTopArea && (
<Toolbar
tabIndex={undefined}
role={undefined}
Expand Down