Skip to content

fix: remove deprecated cra templates #5387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ packages/cypress-commands/dist

scripts
shared
packages/cra-template
CodeGen.tsx
examples

70 changes: 0 additions & 70 deletions .github/workflows/cra-templates.yml

This file was deleted.

4 changes: 0 additions & 4 deletions .reuse/dep5
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ Files: packages/base/src/hooks/useIsomorphicLayoutEffect.ts
Copyright: 2019 Tanner Linsley
License: MIT

Files: packages/cra-template-seed/template/src/hooks/useLocalStorageState.js
Copyright: Kent C. Dodds
License: MIT

Files: packages/base/src/utils/debounce.ts
Copyright: 2009-2021 Jeremy Ashkenas, Julian Gonggrijp, and DocumentCloud and Investigative Reporters & Editors
License: MIT
Expand Down
44 changes: 0 additions & 44 deletions docs/ProjectTemplates.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { Meta } from '@storybook/blocks';
import { Label } from '@ui5/webcomponents-react';
import NextLogo from '@sb/images/logo-nextjs.svg';
import ViteLogo from '@sb/images/logo-vitejs.svg';
import CraLogo from '@sb/images/logo-cra.svg';

<Meta title="Project Templates" />

Expand Down Expand Up @@ -67,49 +66,6 @@ A curated list of project templates to get started using UI5 Web Components for
</ul>
</ProjectTemplate>

<ProjectTemplate
title={'Create React App'}
subtitle={'Basic Template'}
logo={CraLogo}
logoAttribution={
'Create React App Logo. Original Source: https://github.com/facebook/create-react-app/blob/main/docusaurus/website/static/img/logo.svg'
}
href={'https://github.com/SAP/ui5-webcomponents-react/tree/main/packages/cra-template'}
deprecationNotice={'We no longer recommend creating apps using Create React App.'}
>
<ul>
<li>
<Label>Cypress Component Test setup</Label>
</li>
</ul>
</ProjectTemplate>

<ProjectTemplate
title={'Create React App'}
subtitle={'Advanced Template'}
logo={CraLogo}
logoAttribution={
'Create React App Logo. Original Source: https://github.com/facebook/create-react-app/blob/main/docusaurus/website/static/img/logo.svg '
}
href={'https://github.com/SAP/ui5-webcomponents-react/tree/main/packages/cra-template-seed'}
deprecationNotice={'We no longer recommend creating apps using Create React App.'}
>
<ul>
<li>
<Label> Routing using</Label>
<code>react-router-dom</code>
</li>
<li>
<Label>Data Fetching via</Label>
<code>react-query</code>
<Label>, Forms with </Label>
<code>formik</code>
<Label>support</Label>
</li>

</ul>
</ProjectTemplate>

## Community Templates

You can find templates created by our community in the [ui5-web-components-templates](https://github.com/ui5-web-components-templates) organization.
Expand Down
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
"lint": "eslint packages --ext .ts,.tsx",
"lerna:version-dryrun": "lerna version --conventional-graduate --no-git-tag-version --no-push",
"create-webcomponents-wrapper": "node --experimental-json-modules ./packages/main/scripts/create-web-components-wrapper.mjs && node --experimental-json-modules ./scripts/generate-theming-parameters.js",
"examples:recreate-seed": "rimraf examples/seed-test && npx create-react-app examples/seed-test --template file:./packages/cra-template-seed",
"examples:start-seed": "cd examples/seed-test && SKIP_PREFLIGHT_CHECK=true yarn start",
"chromatic": "cross-env STORYBOOK_ENV=chromatic npx chromatic --build-script-name build:storybook",
"postinstall": "husky install && yarn prepare",
"create-cypress-commands-docs": "typedoc && rimraf temp/typedoc"
Expand Down
10 changes: 0 additions & 10 deletions packages/cra-template-seed/.eslintrc.cjs

This file was deleted.

Loading