Skip to content

docs: remove Portals knowledge base entry #6231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2024
Merged

docs: remove Portals knowledge base entry #6231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions docs/knowledge-base/FAQ.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ import { MessageStrip } from '@ui5/webcomponents-react';
<br />
<br />

## Why is my Popover, Dialog, etc. not rendered correctly?

Mounting popups, like the Popover, inside of components can lead to unwanted side-effects (wrong positioning, alignment, etc.), to prevent that we recommend either mounting it outside of the component, or mounting it with a React portal.
You can find out more about how we use portals [here](?path=/docs/knowledge-base-working-with-portals--docs).

## Where can I find all compatible versions of `@ui5/webcomponents` and `@ui5/webcomponents-react`?

All necessary `@ui5/webcomponents` packages are `peerDependencies` of `@ui5/webcomponents-react`, so if you're using npm v7 or later, then these dependencies should be auto installed when running `npm install`.
Expand Down
80 changes: 0 additions & 80 deletions docs/knowledge-base/Portals.mdx
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/compat/src/components/Toolbar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export interface ToolbarPropTypes extends Omit<CommonProps, 'onClick' | 'childre
/**
* Defines where modals are rendered into via `React.createPortal`.
*
* You can find out more about this [here](https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/knowledge-base-working-with-portals--page).
* You can find out more about this [here](https://sap.github.io/ui5-webcomponents-react/v1/?path=/docs/knowledge-base-working-with-portals--page).
*
* Defaults to: `document.body`
*/
Expand Down
Loading