Skip to content

chore: rename test scripts & test compat pkg in CI #6246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
- cypress-commands
- main/src/components
- main/src/internal
- compat
react: ['18', '19']
fail-fast: false
steps:
Expand Down
6 changes: 3 additions & 3 deletions docs/Guidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
## Requirements

- [Yarn](https://yarnpkg.com)
- [Node.js](https://nodejs.org/) (**version 14 or higher** ⚠️)
- [Node.js](https://nodejs.org/) (**[LTS](https://github.com/nodejs/release?tab=readme-ov-file#release-schedule) version** ⚠️)

## Setup your local development environment

Please make sure you have installed `node` 14 or higher (check by running `node -v`) and yarn v1 (check by running `yarn -v`).
Please make sure you have installed a [LTS](https://github.com/nodejs/release?tab=readme-ov-file#release-schedule) `node` version (check by running `node -v`) and yarn v1 (check by running `yarn -v`).

First, you need to clone the git repository by running

Expand All @@ -22,7 +22,7 @@ Then, go into that cloned directory and run `yarn install`. At this point, you a
This starts the local storybook, so you can check if your components are rendered correctly. _If the storybook doesn't open automatically after executing the command, you can use this link: http://localhost:6006/_
- `yarn test` <br />
This command is running all tests in the project.
- `yarn test:cypress:open` <br />
- `yarn test:open` <br />
This command is opening all cypress tests in Chrome.
- `yarn build` <br />
This command executes the full build of the project.
Expand Down
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
"build:storybook": "lerna run build:i18n && yarn create-cypress-commands-docs && storybook build -o .out",
"build:storybook-sitemap": "node ./scripts/create-storybook-sitemap.js --directory .out",
"test:prepare": "rimraf temp && lerna run build",
"test:cypress": "cypress run --component --browser chrome",
"test:cypress:open": "CYPRESS_COVERAGE=false cypress open --component --browser chrome",
"test": "yarn test:prepare && yarn test:cypress",
"test:open": "CYPRESS_COVERAGE=false cypress open --component --browser firefox",
"test": "yarn test:prepare && cypress run --component --browser chrome",
"clean": "tsc --build --clean && tsc --build tsconfig.build.json --clean && rimraf temp .out && lerna run clean",
"clean:remove-modules": "yarn clean && rimraf node_modules",
"prettier:all": "prettier --write --config ./prettier.config.cjs \"packages/**/*.{js,jsx,ts,tsx,mdx,json,md}\"",
Expand Down
2 changes: 1 addition & 1 deletion packages/compat/src/components/Loader/Loader.cy.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { LoaderType } from '../../enums/index.js';
import { LoaderType } from '../../enums/LoaderType.js';
import { Loader } from './index.js';
import { cypressPassThroughTestsFactory } from '@/cypress/support/utils';

Expand Down
Loading